Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need a way to configure fileBackupPrefix of Buffer.Config #443

Open
lawrenceloo opened this issue Apr 11, 2022 · 3 comments
Open

Need a way to configure fileBackupPrefix of Buffer.Config #443

lawrenceloo opened this issue Apr 11, 2022 · 3 comments
Assignees

Comments

@lawrenceloo
Copy link

Hi there, I am now using Fluency in multiple applications that runs in a same server, that is, we have multiple fluency instances run in same server . In order to ease the file resources maintenance of the system, we configure the fileBackupDir to a same system folder.

For example, we have fluency instance A and B run in server 1 and fileBackupDir is C:\backup. During the testing, if we shutdown both instance A and B, both backup file will be saved in C:\backup for both instance A and B. If we start fluency instance A only afterward, we find out that fluency A will read all backup files including instance's B file and flush. However we only want to flush instance A's backup if we start instance A only.

Is it possible to add a parameter fileBackupPrefix inside FluencyBuilder and pass in this property to Buffer.Config? So that we can have different backup file names for different fluency instances. Thanks!

@komamitsu komamitsu self-assigned this Sep 6, 2022
@komamitsu
Copy link
Owner

Why don't you set fileBackupDir for instance A to C:\backup\A so that backup files for instance A and B won't be mixed?

@lawrenceloo
Copy link
Author

Hi @komamitsu there are two reasons:

  1. We have multiple instances, more than 5 in single server, if we define multiple backup folders, we need to have 5+ deployment packages (with different config files), that's more difficult to manage.
  2. So we want to centralize the backup file storage in 1 single folder, this is more easy to maintain (backup/restore/housekeep).

Thanks for your help!

@komamitsu
Copy link
Owner

I still don't get the point. It sounds you still need to maintain 5+ different config files for fileBackupPrefix. I don't think it's better than using fileBackupDir. Also, putting different applications' backup files in a single directory isn't good practice, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants