Solve error in editorJS v2.29.0 #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelnietoa
requested changes
Mar 20, 2024
miguelnietoa
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #122
The issue was related to the editorjs version, in version 2.29.0 the elements with classes
ctandct__contentare rendered after the plugin constructor; in the plugin, these elements are used to customize the tooltip, so the plugin was not set correctly. The solution is to customize the tooltip after the plugin constructor is called, specifically, it is possible to use the pluginrendermethod.The solution was tested in other EditorJS versions without any issues.