-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and improve readme examples #10
Merged
FranciscoMolina02
merged 10 commits into
v0.1.3-dev
from
add-and-improve-examples-to-readme
May 22, 2020
Merged
Add and improve readme examples #10
FranciscoMolina02
merged 10 commits into
v0.1.3-dev
from
add-and-improve-examples-to-readme
May 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanhurtado10
suggested changes
May 20, 2020
juanhurtado10
changed the title
Add and improve examples to readme
Add and improve readme examples
May 21, 2020
FranciscoMolina02
force-pushed
the
add-and-improve-examples-to-readme
branch
from
May 22, 2020 14:39
a88f2db
to
a385731
Compare
juanhurtado10
suggested changes
May 22, 2020
README.md
Outdated
{%XDR.Enum{declarations: [false: 0, true: 1], identifier: true}, <<>>} | ||
``` | ||
|
||
### Boolean | ||
As mentioned before all the XDR types follow the same [Behavior's Declaration](https://github.com/kommitters/elixir_xdr/blob/develop/lib/xdr/declaration.ex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FranciscoMolina02 Based on the new Readme structure this fragment should be located upper
juanhurtado10
approved these changes
May 22, 2020
Pull Request Test Coverage Report for Build cc88f13cb2e3bc9dae18bd6f8318806198a728bc-PR-10
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added examples on README for each missing type