Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and improve readme examples #10

Merged
merged 10 commits into from
May 22, 2020

Conversation

FranciscoMolina02
Copy link
Contributor

Added examples on README for each missing type

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
guides/examples/enumeration.md Outdated Show resolved Hide resolved
@juanhurtado10 juanhurtado10 changed the title Add and improve examples to readme Add and improve readme examples May 21, 2020
@FranciscoMolina02 FranciscoMolina02 force-pushed the add-and-improve-examples-to-readme branch from a88f2db to a385731 Compare May 22, 2020 14:39
README.md Outdated
{%XDR.Enum{declarations: [false: 0, true: 1], identifier: true}, <<>>}
```

### Boolean
As mentioned before all the XDR types follow the same [Behavior's Declaration](https://github.com/kommitters/elixir_xdr/blob/develop/lib/xdr/declaration.ex)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FranciscoMolina02 Based on the new Readme structure this fragment should be located upper

@coveralls
Copy link

Pull Request Test Coverage Report for Build cc88f13cb2e3bc9dae18bd6f8318806198a728bc-PR-10

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 983c717e879af1f3d96116e68d69cc400d4342b9-PR-11: 0.0%
Covered Lines: 356
Relevant Lines: 356

💛 - Coveralls

@FranciscoMolina02 FranciscoMolina02 merged commit 94e6fae into v0.1.3-dev May 22, 2020
@FranciscoMolina02 FranciscoMolina02 deleted the add-and-improve-examples-to-readme branch May 22, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants