Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to:
Remove unused xdr.ex module and its test
XDR.Error.Enum
changed
:not_valid
to:invalid_key
and improve the error messageXDR.Enum
Add missing validation to
encode_xdr/1
review if the declarations have the current keyXDR.Union
Improve the
new/1
function to return an Union structureImprove
decode_union_discriminant/2
with better pattern matchingXDR.VariableArray
remove optional length to the
new/1
function