Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pact resources derived from CommandResult #164

Conversation

miguelnietoa
Copy link
Member

@miguelnietoa miguelnietoa commented Dec 13, 2022

Description

CommandResult is a pretty important resource for Pact API, so this PR adds everything needed for the CommandResult-related resources to work correctly implementing the Mapping module and allowing to build structs from maps coming from Pact API calls.

Closes #163

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@miguelnietoa miguelnietoa merged commit bd01eb6 into kommitters:v0.10 Dec 14, 2022
EdwinGuayacan pushed a commit to EdwinGuayacan/kadena.ex that referenced this pull request Dec 22, 2022
* Implement Pact resources derived from CommandResult

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants