Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Pact request bodies and CommandPayload #181

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Refactor Pact request bodies and CommandPayload #181

merged 2 commits into from
Dec 16, 2022

Conversation

miguelnietoa
Copy link
Member

Description

Fixes #179

Type of change

  • Refactor

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

miguelnietoa and others added 2 commits December 16, 2022 17:10
@miguelnietoa @EdwinGuayacan
Refactor Pact request bodies and CommandPayload
0765488 
Co-authored-by: Juan Hurtado <juan@kommit.co>
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>
@EdwinGuayacan
Improve typespecs in CommandPayload
9f20df4
@miguelnietoa miguelnietoa merged commit e9e90fa into kommitters:v0.10 Dec 16, 2022
EdwinGuayacan added a commit to EdwinGuayacan/kadena.ex that referenced this pull request Dec 20, 2022
@miguelnietoa @EdwinGuayacan
Refactor Pact request bodies and CommandPayload (kommitters#181)
a802006 
* Refactor Pact request bodies and CommandPayload

Co-authored-by: Juan Hurtado <juan@kommit.co>
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>

* Improve typespecs in CommandPayload

Co-authored-by: Juan Hurtado <juan@kommit.co>
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>
Co-authored-by: EdwinGuayacan <80716239+EdwinGuayacan@users.noreply.github.com>
EdwinGuayacan added a commit to EdwinGuayacan/kadena.ex that referenced this pull request Dec 22, 2022
@miguelnietoa @EdwinGuayacan
Refactor Pact request bodies and CommandPayload (kommitters#181)
d928cc5 
* Refactor Pact request bodies and CommandPayload

Co-authored-by: Juan Hurtado <juan@kommit.co>
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>

* Improve typespecs in CommandPayload

Co-authored-by: Juan Hurtado <juan@kommit.co>
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>
Co-authored-by: EdwinGuayacan <80716239+EdwinGuayacan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanhurtado10 juanhurtado10 juanhurtado10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miguelnietoa @juanhurtado10 @EdwinGuayacan