Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SignersList type #192

Merged
merged 3 commits into from
Dec 26, 2022
Merged

Remove SignersList type #192

merged 3 commits into from
Dec 26, 2022

Conversation

EdwinGuayacan
Copy link
Contributor

Fixes #171

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@EdwinGuayacan EdwinGuayacan linked an issue Dec 26, 2022 that may be closed by this pull request
Remove SignersList #171
Closed
3 tasks
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review December 26, 2022 21:09
L-Zuluaga
L-Zuluaga approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It LGTM, everything makes sense 🚀

@EdwinGuayacan EdwinGuayacan merged commit 996f6e8 into kommitters:v0.12 Dec 26, 2022
miguelnietoa pushed a commit that referenced this pull request Dec 27, 2022
@EdwinGuayacan @miguelnietoa
Remove SignersList type (#192)
764f882 
* Remove SignersList type

* Update mix.exs

* remove unnecessary validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Zuluaga L-Zuluaga L-Zuluaga approved these changes

@miguelnietoa miguelnietoa Awaiting requested review from miguelnietoa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove SignersList
2 participants
@EdwinGuayacan @L-Zuluaga