Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retrieve block headers by hash #246

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Add retrieve block headers by hash #246

merged 2 commits into from
Jan 18, 2023

Conversation

Odraxs
Copy link
Contributor

@Odraxs Odraxs commented Jan 18, 2023 •
edited by EdwinGuayacan
Loading

Description

Fixes #224

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Odraxs
Add retrieve block headers by hash
b080bbf 
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>

rebase changes
@Odraxs Odraxs force-pushed the 224-get-block-headers-by-hash branch from 464f829 to b080bbf Compare January 18, 2023 19:53
miguelnietoa
miguelnietoa requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@miguelnietoa miguelnietoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good implementation, minor comments added 🎉

lib/chainweb/client/default.ex Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
lib/chainweb/p2p/block_header_by_hash_response.ex Outdated Show resolved Hide resolved
test/chainweb/p2p/block_header_by_hash_response_test.exs Outdated Show resolved Hide resolved
@EdwinGuayacan EdwinGuayacan merged commit 4526d85 into kommitters:v0.14 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Odraxs @miguelnietoa @EdwinGuayacan