Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mempool endpoint implementation (retrieve pending txs) #254

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Mempool endpoint implementation (retrieve pending txs) #254

merged 3 commits into from
Jan 24, 2023

Conversation

EdwinGuayacan
Copy link
Contributor

Fixes #230

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@EdwinGuayacan EdwinGuayacan linked an issue Jan 23, 2023 that may be closed by this pull request
Get Pending Transactions from the Mempool #230
Closed
EdwinGuayacan and others added 2 commits January 24, 2023 08:50
@EdwinGuayacan @Odraxs
Add mempool endpoint implementation (retrieve txs)
6a287a2 
Co-authored-by: David Roldán <Odraxs@users.noreply.github.com>
@EdwinGuayacan
Fix some names
c31817e
@EdwinGuayacan EdwinGuayacan force-pushed the 230-mempool-retrieve-pending-transactions branch from b0438b8 to c31817e Compare January 24, 2023 13:58
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review January 24, 2023 13:59
L-Zuluaga
L-Zuluaga previously approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

miguelnietoa
miguelnietoa requested changes Jan 24, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
miguelnietoa
miguelnietoa previously approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@miguelnietoa miguelnietoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@EdwinGuayacan EdwinGuayacan changed the base branch from v0.15 to v0.16 January 24, 2023 14:50
@EdwinGuayacan EdwinGuayacan dismissed miguelnietoa’s stale review January 24, 2023 14:50

The base branch was changed.

@EdwinGuayacan EdwinGuayacan merged commit 97a13a6 into kommitters:v0.16 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

@L-Zuluaga L-Zuluaga Awaiting requested review from L-Zuluaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get Pending Transactions from the Mempool
3 participants
@EdwinGuayacan @L-Zuluaga @miguelnietoa