Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAML continuation command implementation #272

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Add YAML continuation command implementation #272

merged 3 commits into from
Feb 1, 2023

Conversation

EdwinGuayacan
Copy link
Contributor

Fixes #209

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@EdwinGuayacan EdwinGuayacan force-pushed the 209-yaml-continuation-command-implementation branch from 450ef7d to 55ffc01 Compare January 31, 2023 15:46
@EdwinGuayacan @Odraxs
Add YAML continuation command implementation
e95e92d 
Co-authored-by: David Roldán <Odraxs@users.noreply.github.com>
@EdwinGuayacan EdwinGuayacan force-pushed the 209-yaml-continuation-command-implementation branch from 55ffc01 to e95e92d Compare January 31, 2023 19:26
@EdwinGuayacan EdwinGuayacan marked this pull request as ready for review January 31, 2023 19:28
@EdwinGuayacan EdwinGuayacan force-pushed the 209-yaml-continuation-command-implementation branch from fdd0077 to 2351d3a Compare January 31, 2023 19:39
@EdwinGuayacan EdwinGuayacan force-pushed the 209-yaml-continuation-command-implementation branch from 2351d3a to 2e33103 Compare January 31, 2023 19:40
@EdwinGuayacan EdwinGuayacan changed the base branch from v0.18 to v0.19 January 31, 2023 22:38
L-Zuluaga
L-Zuluaga previously approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

miguelnietoa
miguelnietoa requested changes Feb 1, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@EdwinGuayacan EdwinGuayacan merged commit 9d19f36 into kommitters:v0.19 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

@L-Zuluaga L-Zuluaga Awaiting requested review from L-Zuluaga

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EdwinGuayacan @L-Zuluaga @miguelnietoa