Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Val types #24

Merged
merged 3 commits into from
May 2, 2023
Merged

Initial Val types #24

merged 3 commits into from
May 2, 2023

Conversation

Odraxs
Copy link
Contributor

@Odraxs Odraxs commented May 1, 2023 •
edited
Loading

Description

Closes #10

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Odraxs Odraxs requested a review from miguelnietoa May 1, 2023 20:12
@Odraxs Odraxs force-pushed the 10-initial-val-types branch 3 times, most recently from 01b5141 to de23889 Compare May 1, 2023 20:17
@Odraxs @CristhianRodriguezMolina
Add initial val types
0ffcfaa 
Co-authored-by: CristhianRodriguezMolina <CristhianRodriguezMolina@users.noreply.github.com>
@coveralls
Copy link

coveralls commented May 1, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build c960b315c34f90afb346d884479ce814b84f7594-PR-24

  • 98 of 98 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 648fb8c6118b61a77c3cd23cd66f74e1ef8d2804: 0%
Covered Lines: 99
Relevant Lines: 99
💛 - Coveralls

miguelnietoa
miguelnietoa requested changes May 2, 2023
View reviewed changes
lib/types/bool.ex Outdated Show resolved Hide resolved
lib/types/bytes.ex Outdated Show resolved Hide resolved
lib/types/spec.ex Outdated Show resolved Hide resolved
lib/types/address.ex Outdated Show resolved Hide resolved
lib/types/spec.ex Outdated Show resolved Hide resolved
@Odraxs @CristhianRodriguezMolina
Add requested changes and stellar_sdk version update
d459fc7 
Co-authored-by: CristhianRodriguezMolina <CristhianRodriguezMolina@users.noreply.github.com>
@Odraxs Odraxs requested a review from miguelnietoa May 2, 2023 22:00
miguelnietoa
miguelnietoa requested changes May 2, 2023
View reviewed changes
lib/types/spec.ex Outdated Show resolved Hide resolved
lib/types/spec.ex Outdated Show resolved Hide resolved
lib/types/string.ex Outdated Show resolved Hide resolved
@Odraxs Odraxs requested a review from miguelnietoa May 2, 2023 22:32
@Odraxs Odraxs merged commit 5227530 into kommitters:v0.2 May 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelnietoa miguelnietoa miguelnietoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Odraxs @coveralls @miguelnietoa