Add contract spec XDR types - Part 1 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CristhianRodriguezMolina
force-pushed
the
228-contract-spec-xdr
branch
from
2199d7e
to
de74ae5
Compare
miguelnietoa
requested changes
Mar 16, 2023
There was a problem hiding this comment.
Well done!👏🏻
I have several suggestions about the folder structure.
I think we can add these types on lib/xdr/contract/spec/
Also for the types string1024, string80, string60, string30... these should be in the lib/xdr/contract/spec folder because they come from the stellar core file called Stellar-contract-spec.x
What do you think?
CristhianRodriguezMolina
force-pushed
the
228-contract-spec-xdr
branch
from
43f21b6
to
85ebd8f
Compare
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #228
In this PR, the following types were added: