Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore main for ESLint compatibility #16

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

thewilkybarkid
Copy link
Contributor

Unfortunately, the import/no-unresolved ESLint rule doesn't yet work without a main property (import-js/eslint-plugin-import#2132). While this package works without it, would you be willing to restore it (until it's fixed) to avoid having to disable the ESLint rule? (Similar to vitejs/vite#8296.)

@kefniark
Copy link
Contributor

LGTM,

thanks for the contribution 👍

@kefniark kefniark merged commit 4cdbe71 into komodojp:develop Sep 29, 2022
@thewilkybarkid thewilkybarkid deleted the package-main branch September 29, 2022 14:48
@kefniark
Copy link
Contributor

This modification was released and published on npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants