Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] HD Wallet implementation #1838

Open
ca333 opened this issue May 26, 2023 · 1 comment
Open

[bug] HD Wallet implementation #1838

ca333 opened this issue May 26, 2023 · 1 comment
Assignees
Labels
blocked requires additional attention bug Something isn't working High priority

Comments

@ca333
Copy link

ca333 commented May 26, 2023

The HD-Wallet implementation is flawed and does not align with the official BIP32/44 standards as we seem only incrementing / deriving on the address index level with a static (potentially config-derived?) account id.

https://github.com/KomodoPlatform/atomicDEX-API/blob/371595d6c0d322e677669544aa37ec6304140fe8/mm2src/crypto/src/standard_hd_path.rs#L18

expectation:

  • multi-wallet support on seed level where each seed = one wallet. (already supported)
  • multi-account support: each asset allows the creation of multiple accounts (for clean "purpose" isolation). i.e. If I create a new account, the account ID needs incremented.
  • multi-address support: each account can then have multiple addresses.
  • if I create a multi-account/address wallet on any other BIP32/44 wallet (Trezor, etc.) I expect to see the same pub-keys for all accounts/addresses as in the corresponding ADEX wallet (with same seed).
  • implementation needs to align with official BIP32/44 standards
@shamardy
Copy link
Collaborator

shamardy commented Aug 11, 2023

Checklist:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked requires additional attention bug Something isn't working High priority
Projects
None yet
Development

No branches or pull requests

2 participants