Added 'debug' flag in values #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OmAximani0
commented
Dec 19, 2022
OmAximani0
commented
- Helps to set environment on debug mode
- Can fix Add value to enable debug logging inside cluster #142
- Helps to set environment on debug mode - Can fix #142
undera
reviewed
Dec 19, 2022
| {{- if .Values.debug }} | ||
| value: 1 | ||
| {{- else }} | ||
| value: 0 |
There was a problem hiding this comment.
AFAIK any non-empty value would enable debugging. So intead of 0 it should be empty string. Also I'd enclosse 1 into quotes to make it YAML string
There was a problem hiding this comment.
Ok @undera sir, I'll do the changes
|
Nice and clean, just address my small comment, please |
|
Amazing, I'll take it from here. |
|
Thank you from
Thank you too for guiding me, I just came here by watching @kunal-kushwaha video https://www.youtube.com/watch?v=hYeNz3M4wT4 for a swag and did a contribution 😎 , Life is unpredictable 😜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.