[WIP] Major release 1.0 #147

undera · 2022-12-22T07:55:13Z

There is some technical debt after initial phase of development, which we plan to address. It means massive changes to backend and frontend, thus it will require a major release. The changes will be accumulated in features-1.0 branch and this PR.

Big changes:

Self-sufficient binary, no Helm or kubectl is needed anymore
Migrate frontend to React

Smaller TODOs:

Namespace troubles (fixes Its allowing only one namespace, where it needs to allow multiple namespaces with out cluster rol #193)
Review the concurrency safety (e.g. repos modifying the files)
Review caching and data reuse
Review introduced TODOs
Review logging
Review unit test coverage (closes Write unit tests for version 1.0 #148)
Test all locally, including namespace variations
Test inside Docker
Test inside cluster

* Code cosmetics * Experimenting with object model and direct HELM usage * Experiment with object model * replacing the kubectl * Progressing * Save the progress * Able to start with migration in mind * Migrated two pieces * List releases via Helm * Forgotten field * Cristallized the problem of ctx switcher * Reworked to multi-context * Rollback is also new style * More migration * Refactoring * Describe via code * Bye-bye kubectl binary * Eliminate more old code * Refactor a bit * Merges * No binaries in dockerfile * Commit * Progress with getting the data * Learned the thing about get * One field less * Sstart with repos * Repo add * repo remove * Repos! Icons! * Simplified access to data * Ver listing works * Ver check works * Caching and values * fixup * Done with repos * Working on install * Install work-ish * Fix UI failing on install * Upgrade flow works * Fix image building * Remove outdated test file * Move files around * REfactorings

* Files import formatted * Added go-test tools * Added test for no-cache header * added changes * test for cache behaviour of app

iamvikaskumar · 2022-12-27T08:02:00Z

Hi, I would like to contribute to the "Migrate frontend to React". Can you please help me get started, thanks.

undera · 2022-12-27T10:04:41Z

Hi, I would like to contribute to the "Migrate frontend to React". Can you please help me get started, thanks.

This task will be done by @ronahk , sorry

iamvikaskumar · 2022-12-27T13:42:36Z

sure, if there is anything else where I can contribute please let me know. I can also help @ronahk if required.

* Test for route configuration * Test for context setter middleware * implemented changes

Fixes #156

- Created `repos_test.go` - Test: `Load()` of Repositories

* Fixes failing test - Fixes failing test of repo loading * handles error for * Did some changes

- and did some code formatting Signed-off-by: OmAxiani0 <aximaniom@gmail.com> Signed-off-by: OmAxiani0 <aximaniom@gmail.com>

- Modified the `repositories.yml` file Signed-off-by: OmAxiani0 <aximaniom@gmail.com> Signed-off-by: OmAxiani0 <aximaniom@gmail.com>

* Test for deleting the repository - Also added cleanup function for `TestAdd` * Fixes failing test

* Add auto labeler for PR's * Add all file under .github/workflow to 'ci' label Co-authored-by: Harshit Mehta <harshitm@nvidia.com>

Co-authored-by: Harshit Mehta <harshitm@nvidia.com>

Relates to #30

…to features-1.0

* Bootstrap OpenAPI doc * Renaming some routes * Listing namespaces * k8s part of things * Repositories section * Document scanners API * One more API call * Progress * Reworked install flow * History endpoint * Textual info section * Resources endpoint * Rollback endpoint * Rollback endpoint * Unit tests * Cleanup * Forgotten tags * Fix tests

undera · 2023-02-01T10:12:13Z

I think this effort has already produced a massive change. React migrating will probably take a lot of time and we should deliver the accumulated changes earlier.
Thus, I'm deciding to proceed with releaseing 1.0.

…res-1.0

harshit-mehtaa · 2023-02-01T10:25:22Z

@undera
Is anything pending for Task 'Review caching and data reuse'?

undera · 2023-02-01T10:30:53Z

@undera Is anything pending for Task 'Review caching and data reuse'?

There's nothing that blocks the release. In fact, the old caching functionality is not used for now, but I think we should restore a bits of it in the future. Also, I've leveraged the browser-side caching in some places.

Fixes #115 Improves #195

…to features-1.0

undera · 2023-02-01T13:24:29Z

To summarize:

Self-sufficient binary, no helm/kubectl requirement
REST API documented
Ability to reconfigure chart with no access to its source
Allow specifying multiple working namespaces
Auto-update repositories when installed into cluster

undera · 2023-02-01T13:30:36Z

many smaller changes

harshit-mehtaa · 2023-02-01T13:39:32Z

When do you plan to create a new release with v1.0?

undera · 2023-02-01T13:43:16Z

I'm preparing to do it today. As soon as we hit the 3K stars mark ;)

harshit-mehtaa · 2023-02-01T13:45:09Z

We already hit 3K 💯 🎉🚀

undera · 2023-02-01T13:46:46Z

Nope. Github makes rounding. If you hover the number on top right, you'll see we are still missing a star.

undera changed the title ~~Major release 1.0~~ [WIP] Major release 1.0 Dec 22, 2022

undera and others added 2 commits December 22, 2022 11:06

Cosmetics

480f2b2

Test for cache control (#151)

2d75ff8

* Files import formatted * Added go-test tools * Added test for no-cache header * added changes * test for cache behaviour of app

test for static route (#153)

f8f5649

OmAximani0 and others added 15 commits December 31, 2022 10:35

Tests: route configuration & context setter (#154)

7e32549

* Test for route configuration * Test for context setter middleware * implemented changes

Restore coverage profile

049b472

Fixes #156

Cosmetics

7e54c58

Test for NewRouter function (#157)

b131482

Test for configureScanners (#158)

c26c705

Test for configureKubectls (#163)

445bb6f

Test for repository loading (#169)

2aa3b32

- Created `repos_test.go` - Test: `Load()` of Repositories

Build all PRs

c90febe

Fixes failing test (#171)

9451a89

* Fixes failing test - Fixes failing test of repo loading * handles error for * Did some changes

Test for listing of repos (#173)

998a5b8

- and did some code formatting Signed-off-by: OmAxiani0 <aximaniom@gmail.com> Signed-off-by: OmAxiani0 <aximaniom@gmail.com>

Test for adding repo (#175)

a7a18ee

- Modified the `repositories.yml` file Signed-off-by: OmAxiani0 <aximaniom@gmail.com> Signed-off-by: OmAxiani0 <aximaniom@gmail.com>

Test for deleting the repository (#176)

356699c

* Test for deleting the repository - Also added cleanup function for `TestAdd` * Fixes failing test

Add auto labeler for PR's (#174)

c754033

* Add auto labeler for PR's * Add all file under .github/workflow to 'ci' label Co-authored-by: Harshit Mehta <harshitm@nvidia.com>

Test for getting repository (#177)

0a65762

Add github workflow for auto PR labeling (#181)

95232bd

Co-authored-by: Harshit Mehta <harshitm@nvidia.com>

github-actions bot added ci api app backend docker github-actions scanners labels Jan 10, 2023

undera mentioned this pull request Jan 20, 2023

HELM_NAMESPACE set leads to resources status failing #132

Closed

undera added 3 commits January 24, 2023 10:32

mute linter

c4d767e

Cosmetics

71e6456

Failing approach to parse manifests

4335cbe

Relates to #30

undera mentioned this pull request Jan 24, 2023

Solve umbrella-chart case #30

Closed

undera and others added 9 commits January 24, 2023 13:11

Report the error properly

ee22baa

✅ Add test for dashboard/objects/data.go NewDataLayer (#199)

37f9a2a

Fix problem of wrong namespace

5de7b99

Merge branch 'features-1.0' of github.com:komodorio/helm-dashboard in…

58cbcfa

…to features-1.0

Added unit tests for releases (#204)

9410ef3

TODOs

f46434a

Rework manifest scanning

8d03ea5

add hasTests flag

326a555

undera marked this pull request as ready for review February 1, 2023 10:09

harshit-mehtaa and others added 2 commits February 1, 2023 10:19

Adding more information on UI for helm test API response (#195)

3876c4a

Merge branch 'main' of github.com:komodorio/helm-dashboard into featu…

9f07f5c

…res-1.0

undera added 2 commits February 1, 2023 10:43

Hide test button when no tests

6cff04d

Fixes #115 Improves #195

Merge branch 'features-1.0' of github.com:komodorio/helm-dashboard in…

178e323

…to features-1.0

undera merged commit e13aa2f into main Feb 1, 2023

undera deleted the features-1.0 branch February 1, 2023 13:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Major release 1.0 #147

[WIP] Major release 1.0 #147

undera commented Dec 22, 2022 •

edited

iamvikaskumar commented Dec 27, 2022

undera commented Dec 27, 2022

iamvikaskumar commented Dec 27, 2022

undera commented Feb 1, 2023

harshit-mehtaa commented Feb 1, 2023

undera commented Feb 1, 2023

undera commented Feb 1, 2023

undera commented Feb 1, 2023

harshit-mehtaa commented Feb 1, 2023 •

edited

undera commented Feb 1, 2023

harshit-mehtaa commented Feb 1, 2023

undera commented Feb 1, 2023

[WIP] Major release 1.0 #147

[WIP] Major release 1.0 #147

Conversation

undera commented Dec 22, 2022 • edited

iamvikaskumar commented Dec 27, 2022

undera commented Dec 27, 2022

iamvikaskumar commented Dec 27, 2022

undera commented Feb 1, 2023

harshit-mehtaa commented Feb 1, 2023

undera commented Feb 1, 2023

undera commented Feb 1, 2023

undera commented Feb 1, 2023

harshit-mehtaa commented Feb 1, 2023 • edited

undera commented Feb 1, 2023

harshit-mehtaa commented Feb 1, 2023

undera commented Feb 1, 2023

undera commented Dec 22, 2022 •

edited

harshit-mehtaa commented Feb 1, 2023 •

edited