Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use github api to fetch latest release version #170

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Use github api to fetch latest release version #170

merged 2 commits into from
Jan 5, 2023

Conversation

harshit-mehtaa
Copy link
Contributor

@harshit-mehtaa harshit-mehtaa commented Jan 5, 2023 •
edited

Changes proposed

  • Use GitHub API to fetch the latest release version of helm-dasboard. On any error, fallback to plugin.yaml to fetch the version

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

Tests

Downloading and installing helm-dashboard v0.3.1 ...
https://github.com/komodorio/helm-dashboard/releases/download/v0.3.1/helm-dashboard_0.3.1_Linux_x86_64.tar.gz

@undera undera merged commit 74aab13 into komodorio:main Jan 5, 2023
@harshit-mehtaa harshit-mehtaa deleted the feat/plugin-install-use-api branch January 5, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harshit-mehtaa @undera