Add option to execute Tests for release #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If PR is not complete, consider turning it into "draft". It's a handy feature in GH, exactly for that. |
harshit-mehtaa
changed the title
|
Note that this will need to be ported to v1.0 |
|
@undera Please help review Will port to be compatible with release v1.0.0 once this is merged |
undera
reviewed
Jan 12, 2023
| return | ||
| } | ||
|
|
||
| c.String(http.StatusAccepted, out) |
There was a problem hiding this comment.
The tests can actually have output and logs. Shouldn't we block until those are returned, and show the result in UI?
There was a problem hiding this comment.
I mean StatusAccepted has meaning "the request is accepted for processing, but it is not complete". If it is complete, the status code should be 200 OK
There was a problem hiding this comment.
Handled in new commit
undera
reviewed
Jan 12, 2023
pkg/dashboard/subproc/data.go
Outdated
| @@ -278,6 +278,17 @@ func (d *DataLayer) ChartInstall(namespace string, name string, repoChart string | |||
| return out, nil | |||
| } | |||
|
|
|||
| func (d *DataLayer) RunTests(namespace string, name string) (string, error) { | |||
| cmd := []string{"test", name, "--namespace", namespace} | |||
There was a problem hiding this comment.
Handled in new commit
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
#115
Changes proposed
helm testCheck List (Check all the applicable boxes)
Screenshots