support for deployment strategy #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually was fighting with the PV claims holding up updates as well. @iiTidgex, were you able to test this change out and verify the pods update nicely? 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
When changing a value in the values file and run upgrade command... both pods remaining running. The old one doesn't terminate and the new one can't start because of Multi-attach error. Same issue as here:
helm/charts#12057
Changes proposed
Added support for to change the strategy used to replace old Pods by new ones.
Check List (Check all the applicable boxes)
Note to reviewers
Intended to fix the same issue as described here -> helm/charts#12057