馃敡 Allow binary arguments via helm chart #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows to pass arguments to the helm chart. This is useful if you want to specify arguments for the helm-dashboard binary whilst deploying via helm.
toddtee
force-pushed
the
allow-arguments-via-helm-chart
branch
from
fa560c0
to
2a78731
Compare
undera
reviewed
Jan 26, 2023
| @@ -111,6 +111,10 @@ autoscaling: | |||
|
|
|||
| nodeSelector: {} | |||
|
|
|||
| extraArgs: | |||
|
Ok, let's try this in the quick minor release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows to pass arguments to the helm chart. This is useful if you want to specify arguments for the helm-dashboard binary whilst deploying via helm.
Fixes Issue
Closes #200 .
Changes proposed
Arguments to the
helm-dashboardbinary can be supplied by utilising theextraArgsparameter within the supplied helm values.Check List (Check all the applicable boxes)