Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Link to the v1.3.0 badge #319

Merged
merged 2 commits into from
Apr 9, 2023
Merged

Conversation

Satyxm
Copy link
Contributor

@Satyxm Satyxm commented Apr 8, 2023

Added link of Release v1.3.0 to the badge of v1.3.0 and it now redirects to the v1.3.0

Changes Proposed

Check List

  • The title of my pull request is a short description of the changes
  • This PR relates to some issue:
  • I have documented the changes made (if applicable)
  • I have covered the changes with unit tests

Added link of Release v1.3.0 to the badge of v1.3.0 and it now redirects to the v1.3.0
@github-actions github-actions bot added the docs label Apr 8, 2023
@undera
Copy link
Collaborator

undera commented Apr 9, 2023

Relates to #318

@undera
Copy link
Collaborator

undera commented Apr 9, 2023

@Satyxm This is not the correct way to fix it. You are hardcoding version number into the link and we'd need to update it with each release. It's too much of manual work.

Instead, please change the link to point to general releases page. The latest release will be on top: https://github.com/komodorio/helm-dashboard/releases

@Satyxm
Copy link
Contributor Author

Satyxm commented Apr 9, 2023

@Satyxm This is not the correct way to fix it. You are hardcoding version number into the link and we'd need to update it with each release. It's too much of manual work.

Instead, please change the link to point to general releases page. The latest release will be on top: https://github.com/komodorio/helm-dashboard/releases

Okay

Added link to the release badge which will now redirect to the latest release
@undera undera merged commit a0bf59e into komodorio:main Apr 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants