Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greedy street duplicate removal removes bus stops #367

Closed
hbruch opened this issue Oct 14, 2018 · 1 comment
Closed

Greedy street duplicate removal removes bus stops #367

hbruch opened this issue Oct 14, 2018 · 1 comment

Comments

@hbruch
Copy link
Collaborator

hbruch commented Oct 14, 2018

Photon removes duplicate results of osm key='highway' with which have the same name and postal code.
This is intended as a street may be split in many ways and only one result should be returned in this case.
However, as results with different osm values get deduplicated, this results in e.g. supressed bus_stops like in the following case:

Searching explicitly for highway:bus_stop returns the bus_stop Thingstraße, searching without osm_tag filter does not.

I think, osm_value should be part of the deduplication key. If this results in (too many) street duplicates, e.g. because the value/classification changes for the various ways of the same street, some more thinking would be required (e.g. distinguishing between bus_stop and street importance values).

hbruch added a commit to mfdz/photon that referenced this issue Oct 15, 2018
Signed-off-by: Holger Bruch <holger.bruch@systect.de>
lonvia added a commit that referenced this issue Oct 15, 2018
Add osm_value to dedupe key (#367)
@lonvia
Copy link
Collaborator

lonvia commented Apr 6, 2019

Fixed in #368.

@lonvia lonvia closed this as completed Apr 6, 2019
Gerungofulus pushed a commit to Gerungofulus/photon that referenced this issue Jun 14, 2019
Signed-off-by: Holger Bruch <holger.bruch@systect.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants