Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase limit to improve de-duplication count #301

Merged
merged 2 commits into from
Jan 29, 2018
Merged

increase limit to improve de-duplication count #301

merged 2 commits into from
Jan 29, 2018

Conversation

karussell
Copy link
Collaborator

Improves #300

@karussell karussell mentioned this pull request Jan 22, 2018
Closed
lonvia
lonvia reviewed Jan 25, 2018
View reviewed changes
Copy link
Collaborator

@lonvia lonvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only increase the limit given to the elasticsearchSearcher. When cutting the result set in line 34, the exact limit can be used again.

@karussell
Copy link
Collaborator Author

Indeed, have fixed this.

@karussell karussell changed the title increase limit to improve dedupplication count increase limit to improve de-duplication count Jan 26, 2018
@karussell karussell added this to the 0.3.0 milestone Jan 26, 2018
@karussell karussell merged commit aeb33f9 into master Jan 29, 2018
@karussell karussell deleted the issue_300 branch January 29, 2018 09:10
@hbruch hbruch mentioned this pull request Mar 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonvia lonvia lonvia left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karussell @lonvia