Make default language configurable #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new command line parameter for choosing the default language returned for queries. If not set the results will returned in the locale form (aka the contents of the 'name' tag without language). As a result of these changes it is now also possible to explicitly ask for locale results with 'lang=default'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new command line parameter for choosing the default language returned for queries. If not set the results will returned in the locale form (aka the contents of the 'name' tag without language).
As a result of these changes it is now also possible to explicitly ask for locale results with 'lang=default'. I'm not particularly attached to using 'default' here. It just happens to be what we call it in the mapping configuration already.
Warning: This PR changes the behaviour of existing installations in that the default is to return the default name tag. You can easily switch back to the old behaviour by setting
-default-language enon the command line.Fixes #441.