Merge b89a064 into 941f594

komposable · Mar 5, 2018 · 68398e9 · 68398e9
2 parents 941f594 + b89a064
commit 68398e9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/features/component_generator.feature b/features/component_generator.feature
@@ -60,6 +60,18 @@ Feature: Component generator
     import "components/awesome_button/awesome_button";
     import "components/button/button";
     """
+
+  Scenario: `imports` in JavaScript files are sorted and without duplicates
+    When I cd to "frontend/components"
+    When I run `rails generate component some_example`
+    When I run `rails generate component some_example`
+    Then the file named "index.js" should contain:
+    """
+    import "components/all/all";
+    import "components/some_example/some_example";
+    import "components/world/world";
+    """
+
   Scenario: Generate component with `erb` template engine
     When I run `rails generate component AwesomeButton`
     And I cd to "frontend/components/awesome_button"

diff --git a/lib/generators/component/component_generator.rb b/lib/generators/component/component_generator.rb
@@ -179,7 +179,7 @@ def sort_lines_alphabetically!(path)
 
     return if lines.empty?
 
-    lines = lines.sort
+    lines = lines.uniq.sort
 
     File.open(path, "w") do |f|
       lines.each do |line|