Fix translation lookup in partials #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 548
💛 - Coveralls |
|
Thanks! I'll take care of refactoring to make Code Climate happy. |
|
Done. Would you mind adding an item in the Changelog, and maybe describe this behavior in the Readme? |
|
Sure thing! I just added a line to the changelog. Do you think it's necessary to explain the behavior in the README? I personally think it's quite intuitive and consistent with the "Rails way". |
florentferry
approved these changes
Aug 24, 2018
Spone
approved these changes
Aug 24, 2018
|
You're right, let's merge :) |
Closed
Spone
pushed a commit
that referenced
this pull request
Feb 26, 2019
* Fix translation lookup in partials * Address namespacing issue outlined in #117 * Refactor Translation#translate to reduce complexity * Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the translation lookup in partials was broken. Using the helper
t('.key')in partialbarwithin a componentfoowould lookup the key in the scope ofbar_componentinstead offoo_component.This PR addresses this issue. In the example above, the resulting key from the helper would be
foo_component.bar.keyThis PR is not compatible with the way komponent handles namespacing at the moment, please do not merge! Refer to #117