Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install generator #127

Merged
merged 5 commits into from
Feb 28, 2019
Merged

Fix install generator #127

merged 5 commits into from
Feb 28, 2019

Conversation

florentferry
Copy link
Member

@florentferry florentferry commented Feb 2, 2019 •
edited
Loading

closes #120

@florentferry florentferry added this to the 3.0 milestone Feb 2, 2019
@Spone Spone mentioned this pull request Feb 2, 2019
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.231%
Totals Coverage Status
Change from base Build 699: 0.0%
Covered Lines: 129
Relevant Lines: 130
💛 - Coveralls

2 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.231%
Totals Coverage Status
Change from base Build 699: 0.0%
Covered Lines: 129
Relevant Lines: 130
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.231%
Totals Coverage Status
Change from base Build 699: 0.0%
Covered Lines: 129
Relevant Lines: 130
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 2, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 711

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.3%) to 91.178%
Totals Coverage Status
Change from base Build 746: -8.3%
Covered Lines: 2005
Relevant Lines: 2199
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 713

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.231%
Totals Coverage Status
Change from base Build 699: 0.0%
Covered Lines: 129
Relevant Lines: 130
💛 - Coveralls

@colbyhub colbyhub mentioned this pull request Feb 14, 2019
Closed
@florentferry florentferry merged commit 743f328 into master Feb 28, 2019
@florentferry florentferry deleted the fix-install-generator branch February 28, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spone Spone Awaiting requested review from Spone

Assignees
No one assigned
Labels
bug
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Readme says install will rename app/javascript to frontend, but no
2 participants
@florentferry @coveralls