Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ComponentHelper in README examples #143

Merged
merged 4 commits into from Sep 18, 2019

Conversation

@AlecRust
Copy link
Contributor

commented Aug 20, 2019

The generator outputs extend ComponentHelper and it seems this is necessary for property underneath.

AlecRust and others added 2 commits Aug 20, 2019
The generator outputs `extend ComponentHelper` and it seems this is necessary for `property` underneath.
@Spone
Spone approved these changes Aug 20, 2019
@Spone

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2019

Thank you for fixing this oversight!

@coveralls

This comment has been minimized.

Copy link

commented Aug 20, 2019

Pull Request Test Coverage Report for Build 910

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.448%

Totals Coverage Status
Change from base Build 814: 0.0%
Covered Lines: 180
Relevant Lines: 181

💛 - Coveralls
@Spone Spone added the documentation label Aug 20, 2019
@Spone

This comment has been minimized.

Copy link
Collaborator

commented Aug 24, 2019

@florentferry do you know why the CI is failing for ruby-head ?

Spone added 2 commits Sep 18, 2019
@Spone

This comment has been minimized.

Copy link
Collaborator

commented Sep 18, 2019

@AlecRust I finally found some time to fix the CI, so I'm now able to merge your PR. Thanks again!

@Spone Spone merged commit 58b0071 into komposable:master Sep 18, 2019
9 checks passed
9 checks passed
Ruby 2.5.x, Rails 5.0.x
Details
Ruby 2.5.x, Rails 5.1.x
Details
Ruby 2.5.x, Rails 5.2.x
Details
Ruby 2.5.x, Rails 6.0.x
Details
Ruby 2.6.x, Rails 5.0.x
Details
Ruby 2.6.x, Rails 5.1.x
Details
Ruby 2.6.x, Rails 5.2.x
Details
Ruby 2.6.x, Rails 6.0.x
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.