-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefixed signature support #48
Comments
can you elaborate a bit more what you propose? |
closing this for now - please reopen with a more clear description what you have in mind here |
I had to add it myself in https://github.com/sigillabs/mobidex/blob/3dcd0783c5743268d795a3d8e6f069ad0c229c7e/android/app/src/main/java/io/mobidex/WalletManagerModule.java#L397. There are two ways that would work:
Idea 2 seems to make the most sense to maintain backwards compatibility. |
I think we should go with option 3 - add a new module with functions to support EIP191 - the function you want can be expressed with this. I do not think it should go into the crypto module - I opened #51 for this |
Perfect! Thank you! |
eth_sign
: https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_sign. Signatures derived frometh_sign
should take on this form:sign(keccak256("\x19Ethereum Signed Message:\n" + len(message) + message)))
. Seems like something wallet providers should handle.The text was updated successfully, but these errors were encountered: