Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepts ERC-67 with a malformed URL #5

Closed
ligi opened this issue Oct 28, 2017 · 2 comments
Closed

Accepts ERC-67 with a malformed URL #5

ligi opened this issue Oct 28, 2017 · 2 comments

Comments

@ligi
Copy link
Member

ligi commented Oct 28, 2017

Follow up from #4 :
I think the problem of the user came from a malformed URL as tests showed that parsing ERC-67 that contains gas works
I could reproduce the problem with a malformed URL that looks like this:
ethereum:0xabc?value=100000000?gas=2030000000000000000

then in WALLETH the gas-value from is taken as value as described here:
https://www.reddit.com/r/ethereum/comments/78wj3s/erc67_support_by_ethereum_wallet_providers_so/

Fix is to detect ERC-67 as invalid when gas or value are not plain numbers

@issueth
Copy link

issueth bot commented Oct 28, 2017

This issue now has a bounty-address via issuETH.

Your bounty-address is 91622b65f65d2b724822beb455083514ba91a9a7
Watch on rinkeby
Watch on main

@ligi ligi closed this as completed in 4c7f994 Oct 28, 2017
@issueth
Copy link

issueth bot commented Oct 28, 2017

This issue was closed but had no assignee - to get the bounty-account you need to close the issue with one assignee!

ligi added a commit to walleth/walleth that referenced this issue Oct 29, 2017
ligi added a commit to walleth/walleth that referenced this issue Oct 29, 2017
jewel528 added a commit to jewel528/walleth that referenced this issue Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant