Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/366: Serve pprof using the same server as the application #373

Closed
wants to merge 3 commits into from

Conversation

komuw
Copy link
Owner

@komuw komuw commented Aug 31, 2023

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 62.42% and project coverage change: -1.35% ⚠️

Comparison is base (c1f3b86) 74.64% compared to head (90335d7) 73.30%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   74.64%   73.30%   -1.35%     
==========================================
  Files          44       46       +2     
  Lines        5270     5380     +110     
==========================================
+ Hits         3934     3944      +10     
- Misses       1068     1167      +99     
- Partials      268      269       +1     
Files Changed Coverage Δ
mux/mux.go 0.00% <0.00%> (-72.73%) ⬇️
mux/route.go 0.00% <0.00%> (-90.41%) ⬇️
server/pprof.go 39.51% <0.00%> (-47.99%) ⬇️
internal/mx/mx.go 65.33% <65.33%> (ø)
server/server.go 75.67% <88.00%> (-0.23%) ⬇️
internal/mx/route.go 90.97% <90.97%> (ø)
internal/acme/acme.go 74.48% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@komuw komuw mentioned this pull request Aug 31, 2023
@komuw
Copy link
Owner Author

komuw commented Sep 1, 2023

superseded by #375

@komuw komuw closed this Sep 1, 2023
@komuw komuw deleted the issues/366-pprof branch September 1, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pprof server should also be available over https with redirection
2 participants