Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lstrip domain name if wildacrd #139

Merged
merged 4 commits into from
Mar 15, 2020
Merged

lstrip domain name if wildacrd #139

merged 4 commits into from
Mar 15, 2020

Conversation

komuw
Copy link
Owner

@komuw komuw commented Feb 3, 2020

Thank you for contributing to sewer.
Every contribution to sewer is important to us.
You may not know it, but you have just contributed to making the world a more safer and secure place.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to sewer, and sewer agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that sewer shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • if we have been given a wildcard name, strip wildcard before trying to delete it

Why(Why did you change it?)

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #139 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   86.42%   86.44%   +0.01%     
==========================================
  Files          14       14              
  Lines         943      944       +1     
==========================================
+ Hits          815      816       +1     
  Misses        128      128
Impacted Files Coverage Δ
sewer/dns_providers/cloudflare.py 93.24% <100%> (+0.09%) ⬆️
sewer/__version__.py 100% <100%> (ø) ⬆️

@komuw komuw marked this pull request as ready for review March 15, 2020 11:58
@komuw komuw merged commit ee0f259 into master Mar 15, 2020
@komuw komuw deleted the issues/134 branch March 15, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudflare TXT record is not removed
1 participant