Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation; JSON catalogs; library support #200

Merged
merged 1 commit into from
Aug 9, 2020
Merged

Conversation

mmaney
Copy link
Collaborator

@mmaney mmaney commented Aug 5, 2020

Add catalog.json, replacing ad-hoc lists of providers in cli.py & setup.py.
catalog.py for easy use of the catalog, including loading known providers.
Add sewer.json info replaces __version__.py; sewer_about in lib to access it.

@mmaney mmaney force-pushed the 0.8 branch 4 times, most recently from 6543d41 to 4550103 Compare August 5, 2020 15:01
@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #200 into master will increase coverage by 0.48%.
The diff coverage is 94.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
+ Coverage   87.79%   88.28%   +0.48%     
==========================================
  Files          18       19       +1     
  Lines        1131     1195      +64     
==========================================
+ Hits          993     1055      +62     
- Misses        138      140       +2     
Impacted Files Coverage Δ
sewer/client.py 92.13% <90.00%> (ø)
sewer/catalog.py 95.23% <95.23%> (ø)
sewer/lib.py 100.00% <100.00%> (ø)
sewer/dns_providers/unbound_ssh.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 285b17e...15e7a6d. Read the comment docs.

Add catalog.json, replacing ad-hoc lists of providers in cli.py & setup.py.
catalog.py for easy use of the catalog, including loading known providers.
Add sewer.json info replaces __version__.py; sewer_about in lib to access it.
Rework GET, HEAD and POST for better mypy compatibility with less hacks.
@mmaney mmaney merged commit 4bcd909 into komuw:master Aug 9, 2020
@mmaney mmaney deleted the 0.8 branch August 9, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant