Skip to content

Commit

Permalink
Pass the --enable-deprecated-beta-topology-labels flag to cloud-nod…
Browse files Browse the repository at this point in the history
…e-manager, not cloud-controller-manager (gardener#717)

gardener#716 added the flag to cloud-controller-manager. This fails with:
```
Error: unknown flag: --deprecated-apply-beta-topology-labels
```

The flag is supported for cloud-node-manager. See kubernetes-sigs/cloud-provider-azure#3685.
  • Loading branch information
ialidzhikov authored and kon-angelo committed Aug 8, 2023
1 parent fcf5bbc commit 4a39160
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ spec:
- --tls-cipher-suites={{ .Values.tlsCipherSuites | join "," }}
- --use-service-account-credentials
- --v=2
{{- if semverCompare ">= 1.26.0-0, < 1.28.0-0" .Values.kubernetesVersion }}
- --deprecated-apply-beta-topology-labels=true
{{- end }}
livenessProbe:
httpGet:
path: /healthz
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ spec:
- cloud-node-manager
- --node-name=$(NODE_NAME)
- --wait-routes=true # only set to true when --configure-cloud-routes=true in cloud-controller-manager.
{{- if semverCompare ">= 1.26.0-0, < 1.28.0-0" .Capabilities.KubeVersion.GitVersion }}
- --enable-deprecated-beta-topology-labels=true
{{- end }}
env:
- name: NODE_NAME
valueFrom:
Expand Down

0 comments on commit 4a39160

Please sign in to comment.