Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopen app after language settings changed. #82

Closed
konifar opened this issue Feb 8, 2016 · 7 comments
Closed

Reopen app after language settings changed. #82

konifar opened this issue Feb 8, 2016 · 7 comments
Assignees
@hotchemi
Labels
feature
Milestone
1.0.0

Comments

@konifar
Copy link
Owner

konifar commented Feb 8, 2016

Remove snackbar confirmation.
https://github.com/konifar/droidkaigi2016/blob/master/app/src/main/java/io/github/droidkaigi/confsched/fragment/SettingsFragment.java#L93-L100
@konifar konifar added this to the 1.0.0 milestone Feb 8, 2016
@hotchemi
Copy link
Contributor

hotchemi commented Feb 9, 2016

I guess title and detail say different stuff, which is correct?

@KeithYokoma
Copy link
Collaborator

I think I'm in charge of removing snackbar confirmation so the title is correct.

@hotchemi
Copy link
Contributor

hotchemi commented Feb 9, 2016

Gotcha.

hotchemi pushed a commit that referenced this issue Feb 9, 2016
Fix #82.
4516a03
@hotchemi hotchemi mentioned this issue Feb 9, 2016
Merged
@hotchemi hotchemi added in progress and removed ready labels Feb 9, 2016
@konifar
Copy link
Owner Author

konifar commented Feb 9, 2016

Sorry, description is correct.

When the user change language, snackbar is shown as confirmation to restart app. I guess confirmation is not necessary, so want to remove snackbar.

@KeithYokoma
Copy link
Collaborator

oh i c

@hotchemi
Copy link
Contributor

hotchemi commented Feb 9, 2016

Created PR.

@konifar
Copy link
Owner Author

konifar commented Feb 9, 2016

Great thanks!

@konifar konifar closed this as completed Feb 9, 2016
@konifar konifar reopened this Feb 9, 2016
@konifar konifar closed this as completed Feb 9, 2016
@konifar konifar reopened this Feb 9, 2016
hotchemi added a commit that referenced this issue Feb 9, 2016
@hotchemi
Merge pull request #92 from konifar/hotchemi/82
51661f2 
Fix #82.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hotchemi hotchemi

Labels
feature
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@hotchemi @KeithYokoma @konifar