New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
notification setting #189
notification setting #189
Conversation
@@ -71,7 +71,6 @@ | |||
|
|||
<receiver | |||
android:name=".receiver.SessionScheduleReceiver" | |||
android:process=":remote" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this attribute to get correct SharedPreferences value.
I used page below as reference.
http://stackoverflow.com/questions/10098981/sharedpreferences-in-broadcastreceiver-seems-to-not-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ic.
Could you send screenshot? 🙇 |
android:layout_width="match_parent" | ||
android:layout_height="wrap_content" | ||
android:background="@drawable/clickable" | ||
android:padding="@dimen/spacing"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is better that user can click this layout to switch change. How do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. I'll try 💨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it ⬇️
LGTM! |
This PR is for #168 .
User can choose whether to receive notifications.