Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added movie urls for any sessions which videos are currently available on YouTube #333

Merged
merged 4 commits into from
Feb 28, 2016
Merged

Added movie urls for any sessions which videos are currently available on YouTube #333

merged 4 commits into from
Feb 28, 2016

Conversation

shoheikawano
Copy link
Contributor

Corresponding issue: #327

Done

Added movie urls for any sessions which videos are currently available on YouTube.

I thought we have to just wait until videos for all sessions are available, but thought "screw it!"; I just decided to fill out currently available ones and make PR for it if that's possible.

Sessions with empty movie_url

  • 史上最速のAndroid
  • Androidの最新動向
  • What's the difference between JavaScript and Java?
  • Android CI: 2016 edition
  • 5年続く「はてなブックマーク」アプリを継続開発する技術
  • Fireside chat

@shoheikawano shoheikawano changed the title Sk/session ja movies almost Added movie urls for any sessions which videos are currently available on YouTube Feb 28, 2016
@hotchemi
Copy link
Contributor

Nice!

@konifar
Copy link
Owner

konifar commented Feb 28, 2016

Great work...!

@konifar
Copy link
Owner

konifar commented Feb 28, 2016

I'm sorry... If you have time, could you add movie urls to sessions_ko.json ?

@shoheikawano
Copy link
Contributor Author

I'm sorry... If you have time, could you add movie urls to sessions_ko.json ?

oh sorry i totally missed that json file.. of course I will! Thank you for letting me know! 😆

@konifar
Copy link
Owner

konifar commented Feb 28, 2016

Thanks!! LGTM!

konifar added a commit that referenced this pull request Feb 28, 2016
Added movie urls for any sessions which videos are currently available on YouTube
@konifar konifar merged commit 65374ab into konifar:master Feb 28, 2016
@konifar konifar mentioned this pull request Feb 28, 2016
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants