Add 3 new movie urls #363
Merged
Add 3 new movie urls #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -984,7 +984,7 @@ | |||
| }, | |||
| "language_id": "ja", | |||
| "slide_url": "https://speakerdeck.com/player/45c463463fbe47518576240a53622cdc", | |||
| "movie_url": "https://www.youtube.com/watch?v=GMAXZPndBo0", | |||
| "movie_url": "https://www.youtube.com/watch?v=lmti0rNxbmI", | |||
There was a problem hiding this comment.
I'm guessing when I added movie urls for the first time I added the wrong one, so here I modified it to add the right one.
|
馃憖 |
|
@shaunkawano Thanks!! |
|
@konifar Thanks for the review! Yes, I realized that Circle CI failed due to this: http://stackoverflow.com/questions/29063968/plugin-is-too-old-please-update-to-a-more-recent-version-or-set-android-daily; I'm guessing it should be fixed by updating Gradle verson. http://stackoverflow.com/a/29064084/5449688 |
|
@shaunkawano Oh, thanks. I appreciate that you fix this if you have a time 馃檱 |
|
Could you merge master to this branch? |
|
馃槃 Circle CI check successful! |
|
Thanks so much!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #334
Done
I added 3 new movie urls: #334 (comment) (finally 馃檱 )