Fix #199 #200
Merged
Fix #199 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9t
requested changes
Jul 31, 2018
| @@ -12,7 +12,7 @@ | |||
| from konlpy import utils | |||
|
|
|||
|
|
|||
| def init_jvm(jvmpath=None): | |||
| def init_jvm(jvmpath=None, max_heap_size=1024): | |||
| """Initializes the Java virtual machine (JVM). | |||
|
|
|||
| :param jvmpath: The path of the JVM. If left empty, inferred by :py:func:`jpype.getDefaultJVMPath`. | |||
There was a problem hiding this comment.
:param max_heap_size:
이하에 간단한 설명 추가 부탁드립니다. (ex: Heap size를 언제 늘리면 좋은지, 너무 많이 늘리면 어떤 문제가 생기는지 등)
There was a problem hiding this comment.
init_jvm 및 jvm 을 이용하는 태거들의 param 에 설명을 추가하였습니다.
e9t
requested changes
Aug 1, 2018
konlpy/tag/_hannanum.py
Outdated
| @@ -60,6 +60,7 @@ class Hannanum(): | |||
| [('웃', 'P'), ('으면', 'E'), ('더', 'M'), ('행복', 'N'), ('하', 'X'), ('ㅂ니다', 'E'), ('!', 'S')] | |||
|
|
|||
| :param jvmpath: The path of the JVM passed to :py:func:`.init_jvm`. | |||
| :param max_heap_size: The path of the JVM passed to :py:func:`.init_jvm`. | |||
There was a problem hiding this comment.
Ooops, seems like a ctrl+c/v error :)
(Same goes to the two files below)
e9t
requested changes
Aug 1, 2018
konlpy/jvm.py
Outdated
| """Initializes the Java virtual machine (JVM). | ||
|
|
||
| :param jvmpath: The path of the JVM. If left empty, inferred by :py:func:`jpype.getDefaultJVMPath`. | ||
| :param max_heap_size: Maximum memory usage limitation (Megabyte). Default is 1024 (1Gb). If you set this value too small, you may got out of memory. We recommend that you set it 1024 ~ 2048 or more at least. However, if this value is too large, you may see inefficient memory usage. |
There was a problem hiding this comment.
Default is 1024 (1Gb) -> Default is 1024 (1GB)
Gb is normally the symbol for Gigabits.
|
LGTM! Let's ship this in 0.5.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jvm 구동 시 최대 메모리 사용량 제약을 각 tagger 의 argument 로 넣어뒀습니다.