Clean up deprecated streaming api #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#263, #266 사용자분들께서 dependency가 늘어나 package의 설치 등에 어려움을 겪거나 패키지 자체가 무거워지는 등의 현상을 피하고자, 제가 이전 추가했었으나 따로 문서화되어 있지 않았으며 최신 웹사이트 스트리밍 등을 지원하도록 업데이트되지 않았던 koshort 패키지에서 추가된 streaming api 부분들을 삭제하려고 합니다.
해당 스트리밍 기능은 여전히 별도의 패키지인 koshort 에서 보존되고 있으며, 이쪽에서 유지보수를 하는 것이 사용자들의 혼란을 줄일 수 있을 것으로 생각됩니다.
리뷰 부탁드립니다 :) @e9t