Fix #309 to pass make check
#340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requirements2.txt should be included in source distribution. It allows setup.py to read the file on python2.
Make check-manifest ignore those files or it fails. Check-manifest checks if all git-tracking files excluding files to be ignored are same as files in source distribution.
Removed redundant spaces and a comma. Added guides to be ignored on checking pep8.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
저도 #309 와 같은 이슈가 생겨서 수정 사항을 제안해봅니다.
requirements2.txt를 MANIFEST.in에 추가
파이썬2로 konlpy를 설치하려면 requirements2.txt가 패키지에 포함되어야 할 거 같습니다.
check-manifest --ignore 옵션 추가
check-manifest가 git의 파일들과 소스 distribution 파일들의 같은지 비교하는 것 같습니다.소스 distribution에 없어도 되는 git의 파일들을 무시하도록 지정했습니다.
pep8 스타일 가이드대로 수정
사소한 것들은 수정했고,
몇 가지는 코드를 놔둔 채 가이드를 무시하도록 룰을 추가했습니다.