Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel Blank Rows Calls mutateBeforeCreate (#66) #67

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

byt3sage
Copy link
Contributor

@byt3sage byt3sage commented Jan 11, 2023

Proposed changes

So this is linked to #66. Basically, I wanted to add in a way to filter out blank rows (excel blank rows not just rows with no data). Although I feel this would be beneficial to have enabled by default, I didn't want to break peoples own implementations of handling this such as handing this in the handleRecordCreation() function although I cannot think of a valid use case where people would want to import these blank rows. I'm happy to be led by maintainers as to if we enable this by default or not, I just didn't want to unleash a potentially breaking change.

I'm happy to provide a spreadsheet which includes these blank rows if you would like to see this.

Types of changes

What types of changes does your code introduce to Filament Import?
Put an x in the boxes that apply

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

I will update the documentation now, I also need to run the tests locally (just had a few issues getting them running on my work machine) and I do think it would be beneficial to add in a test which covers these blank rows although I don't think this PR should be dependent on that.

@byt3sage
Copy link
Contributor Author

So local tests are fine, we probably need to have a think if you want to merge this feature, on how we implement the test for this. I think we're going to need to include an .xlsx file in the tests folder which contains these blank rows as this is excel specific.

@frankyso frankyso merged commit ffa5b65 into konnco:main Jan 19, 2023
@frankyso
Copy link
Member

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants