Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt new website #142

Merged
merged 7 commits into from
Dec 18, 2019
Merged

Adapt new website #142

merged 7 commits into from
Dec 18, 2019

Conversation

dohseven
Copy link
Collaborator

@dohseven dohseven commented Dec 6, 2019

This MR is a starting point for adapting the konnector to the new websites deployed by CA (see #90). It is far from complete, as I don't have much to parse on my personal accounts, but it should work in most cases.

I hope I didn't break anything for the old website parsing, but I wasn't able to test it.

@dohseven dohseven requested a review from a team as a code owner December 6, 2019 16:53
doubleface
doubleface previously approved these changes Dec 9, 2019
src/lib.js Show resolved Hide resolved
@doubleface
Copy link
Contributor

doubleface commented Dec 9, 2019

@dohseven : pas grand chose à dire sinon merci. Le login passe pour mon compte en standalone et les différents comptes sont bien récupérés. Il y a par contre un soucis pour la liste d'opérations :

TypeError: Cannot read property 'forEach' of undefined
at Object.parseNewOperations (/home/doubleface/Workspace/connectors/cragr/src/lib.js:455:17)
at syncOperations (/home/doubleface/Workspace/connectors/cragr/src/lib.js:328:16)
at async BaseKonnector.start (/home/doubleface/Workspace/connectors/cragr/src/lib.js:93:24)

Ca doit être à cause d'une spécificité de mon compte. Je vais voir ce que je peux t'apporter comme informations.

Pour ce qui est de l'ancienne version que tu essaye de maintenir, je crois que c'est inutile. On ne la maintient plus depuis longtemps et je pense que l'ancien site n'existe plus, à moins que tu aies d'autres informations.

@dohseven
Copy link
Collaborator Author

dohseven commented Dec 9, 2019

@doubleface J'avais lu je ne sais plus où que la migration des caisses locales serait progressive. En tapant au hasard, je suis arrivé sur la Franche Comté par exemple qui conserve encore l'ancien site : https://www.ca-franchecomte.fr/particuliers.html

Je ne sais pas si c'est nécessaire de garder le konnecteur fonctionnel pour ce peu de sites pendant ce peu de temps de migration, mais dans le doute, je préférais garder l'existant !

@doubleface
Copy link
Contributor

@doubleface J'avais lu je ne sais plus où que la migration des caisses locales serait progressive. En tapant au hasard, je suis arrivé sur la Franche Comté par exemple qui conserve encore l'ancien site : ca-franchecomte.fr/particuliers.html

Bien vu !

@doubleface doubleface dismissed their stale review December 9, 2019 10:02

Found a problem

src/lib.js Show resolved Hide resolved
@dohseven
Copy link
Collaborator Author

@doubleface The PR is ready for review, even if there is a requested change, I didn't find how to make it disappear

@doubleface
Copy link
Contributor

Works perfectly for my accounts in standalone. Thanks @dohseven 👍

@doubleface doubleface merged commit 671d572 into konnectors:master Dec 18, 2019
doubleface pushed a commit that referenced this pull request Dec 18, 2019
@dohseven dohseven deleted the adapt-new-website branch December 18, 2019 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants