Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle PDF generation #212

Open
laedit opened this issue May 3, 2018 · 3 comments
Open

Handle PDF generation #212

laedit opened this issue May 3, 2018 · 3 comments

Comments

@laedit
Copy link
Contributor

laedit commented May 3, 2018

For websites that don't propose PDF files (like The Old Reader and Booking 馃槈 ).

I think that there are at least two levels:

  • the "I don't want to touch at the pdf" high level, like the html2pdf in the booking konnector
  • the "I want to decide how the pdf will look" low level, for cases when the html can't be rendered in pdf

The high level could be a method which takes either an url or an html fragment to be converted.

The low level could just expose the pdfjs api to a dedicated namespace?
The last version simplify the doc creation (no mandatory font, defaults to helvetica) and the resulting document inherits directly from Readable, so there is no more _doc field.

@doubleface
Copy link
Collaborator

The is also a need to find a way to add images in PDF files even when the connector is built with webpack

@laedit
Copy link
Contributor Author

laedit commented May 3, 2018

Does it works for remote images or not at all?
I haven't got the time to check it.

@doubleface
Copy link
Collaborator

I will try to check it. It was just a reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants