Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nifi-cluster Helm chart #141

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

mh013370
Copy link
Member

@mh013370 mh013370 commented Aug 23, 2022

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #102
License Apache 2.0

What's in this PR?

This PR contains a new helm chart called nifi-cluster which makes it possible to deploy all of the following in a single deployment:

  • NifiCluster
  • Zero or more NifiUser
  • Zero or more NifiDataflow
  • Zero or more NifiRegistryClient
  • Zero or more NifiParameterContext
  • Zero or more NifiUserGroup
  • Zero or more NifiNodeGroupAutoscaler, including the associated HorizontalPodAutoscaler

It also allows for creating:

  • An optional dependent zookeeper cluster specifically for this NifiCluster via the bitnami zookeeper chart
  • Prometheus Operator ServiceMonitor for metric scraping
  • BanzaiCloud Logging Operator logging Flow for log aggregation
  • Kubernetes Ingress
  • Extra arbitrary manifests, which are useful to generate secrets containing sensitive properties referred to in NifiParameterContext resources

The nifikop and nifi-cluster charts will be versioned together to ensure that compatibility is clear.

Why?

To ease the deployment of NifiCluster resources with all of the supporting custom resources.

Additional context

We've been running this for some time and it works well for our needs.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@mh013370 mh013370 changed the title updated CI to publish nifi-cluster chart Added nifi-cluster Helm chart Aug 23, 2022
@mh013370 mh013370 mentioned this pull request Sep 26, 2022
1 task
@mh013370
Copy link
Member Author

I will update this PR to specify API version v1 now that nifikop 1.0.0 has been released.

update changelog
add dependency update to helm-package task in makefile
add controllerUserIdentity to nifi cluster template
add NifiNodeGroupAutoscaler template

update changelog

add horizontal pod autoscaler template
@mh013370
Copy link
Member Author

mh013370 commented Dec 1, 2022

Alright i've updated this chart with all v1 resources (except the v1alpha1.NodeGroupAutoscaler).

@erdrix : Would it be possible to pursue merging this so we can avoid maintaining this separately? Do you see any major issues with it?

Once we begin working toward merging this, i will update the user guide with instructions like we have for the nifikop helm chart.

@mh013370
Copy link
Member Author

@erdrix , @juldrixx : Any issue with getting this into master? It would drastically simplify NifiCluster deployments from many CRDs into a helm install command.

Copy link
Contributor

@erdrix erdrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, but if we want it to have a chance to be used, we might want to think about adding a documentation section in another PR :)

@erdrix erdrix merged commit 6a2dee9 into konpyutaika:master Mar 30, 2023
@mh013370
Copy link
Member Author

Good for me, but if we want it to have a chance to be used, we might want to think about adding a documentation section in another PR :)

I'm on it :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create helm chart for NifiCluster and referencing resources
2 participants