Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for staticcheck and govuln #245

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Adding support for staticcheck and govuln #245

merged 3 commits into from
Mar 29, 2023

Conversation

r65535
Copy link
Contributor

@r65535 r65535 commented Mar 24, 2023 •
edited

Q A
Bug fix? yes
New feature? yes
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Why?

To reduce errors and vulnerabilities

Additional context

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

mh013370
mh013370 approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@mh013370 mh013370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mh013370 mh013370 merged commit 4403b66 into konpyutaika:master Mar 29, 2023
@r65535
Copy link
Contributor Author

r65535 commented Mar 29, 2023

Thanks for reviewing! 🚀

@r65535 r65535 deleted the fixing-staticcheck-issues branch March 29, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mh013370 mh013370 mh013370 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r65535 @mh013370