Add AuthenticationStrategy, ManagerDn, ManagerPassword, IdentityStrat… #266
+44
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mh013370
reviewed
Jun 28, 2023
mh013370
reviewed
Jun 28, 2023
mh013370
reviewed
Jun 28, 2023
mh013370
reviewed
Jun 28, 2023
|
Can you please update the changelog with the changes? Otherwise, this LGTM and i can merge afterwards. |
pashtet04
added a commit
to pashtet04/nifikop
that referenced
this pull request
Jul 7, 2023
mh013370
approved these changes
Jul 7, 2023
|
Ah apologies - all commits need to be signed 😄 Then i can merge. |
pashtet04
added a commit
to pashtet04/nifikop
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Pavel Klyuev <pashtet04@gmail.com>
pashtet04
added a commit
to pashtet04/nifikop
that referenced
this pull request
Jul 7, 2023
Signed-off-by: Pavel Klyuev <pashtet04@gmail.com>
|
Verified |
pashtet04
added a commit
to pashtet04/nifikop
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Pavel Klyuev <pashtet04@gmail.com>
pashtet04
added a commit
to pashtet04/nifikop
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Pavel Klyuev <pashtet04@gmail.com>
pashtet04
added a commit
to pashtet04/nifikop
that referenced
this pull request
Jul 10, 2023
Signed-off-by: Pavel Klyuev <pashtet04@gmail.com>
pashtet04
force-pushed
the
master
branch
2 times, most recently
from
5931017
to
e4d45f5
Compare
…egy properties for LDAP integration Signed-off-by: Pavel Klyuev <pashtet04@gmail.com>
|
Thank you for the contribution! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…egy properties for LDAP integration
What's in this PR?
Add AuthenticationStrategy, ManagerDn, ManagerPassword, IdentityStrategy properties for LDAP integration
Why?
Because LDAP can be secured
Checklist
To Do