Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check to control if a dataflow is unscheduled in order to schedule it #279

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Aug 2, 2023

Q A
Bug fix? yes
New feature? yes
API breaks? no
Deprecations? no
Related tickets -
License Apache 2.0

What's in this PR?

New check to control if a dataflow is unscheduled in order to schedule it.

Why?

To prevent spamming Start and Enable and overflowing of the Flow History Configuration

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx changed the title Add check to control if a dataflow is unscheduled in order to schedule it Added check to control if a dataflow is unscheduled in order to schedule it Aug 2, 2023
@juldrixx juldrixx requested a review from mh013370 August 2, 2023 09:23
@mh013370
Copy link
Member

mh013370 commented Aug 2, 2023

Would a dataflow be unscheduled on first deployment? Can you describe what scenarios this condition presents itself?

@juldrixx
Copy link
Contributor Author

juldrixx commented Aug 2, 2023

Would a dataflow be unscheduled on first deployment? Can you describe what scenarios this condition presents itself?

It works the same as before. Only, instead of constantly starting and activating processors and services, we check whether any processors or services are switched off. Any point of caution?

@juldrixx juldrixx merged commit 406001a into master Aug 2, 2023
1 check passed
@juldrixx juldrixx deleted the feat/check_if_unscheduled branch August 2, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants