-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/NifiCluster] Add ability to set container port network protocol #320
[Feature/NifiCluster] Add ability to set container port network protocol #320
Conversation
That still doesn't work. If you change the default value to |
well isn't this a fun problem 😄 |
Even more when we have // +kubebuilder:validation:Enum={"DO_NOT_LOAD_BALANCE","PARTITION_BY_ATTRIBUTE","ROUND_ROBIN","SINGLE"}
type ConnectionLoadBalanceStrategy string // how to load balance the data in this Connection across the nodes in the cluster.
// +kubebuilder:default="DO_NOT_LOAD_BALANCE"
LoadBalanceStrategy ConnectionLoadBalanceStrategy `json:"loadBalanceStrategy,omitempty" that gives us loadBalanceStrategy:
default: DO_NOT_LOAD_BALANCE
enum:
- DO_NOT_LOAD_BALANCE
- PARTITION_BY_ATTRIBUTE
- ROUND_ROBIN
- SINGLE
type: string And I can change the default value |
If you change the type from |
I guess, you can rollback to how it was before without default annotation. It's fine. |
Hmm. I was hoping to use the k8s types for ease of use and to avoid converting to/from string and I can either change it to a string or remove the default. Which would you prefer? |
Remove the default, I asked on Kubebuilder slack how to do it. I'm still waiting for an answer, but depending on the response, I'll make the appropriate change in the future. |
pushed |
What's in this PR?
Adds the ability to set the NiFi container port network protocol. This field is new and optional, defaulting to
TCP
. If one wished to set the protocol for all container ports, you would use the following:Why?
It's not currently possible to set anything other than TCP.
Checklist