Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/NifiCluster] Add abitility to set nodePort #323

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

juldrixx
Copy link
Contributor

@juldrixx juldrixx commented Nov 15, 2023

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets fixes #283
License Apache 2.0

What's in this PR?

Adds the ability to set the NodePort Service nodePort. This field is new and optional, defaulting to nothing.

Why?

By default and for convenience, the Kubernetes control plane will allocate a port from a range (default: 30000-32767) but some users want to specify it.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline
  • User guide and development docs updated (if needed)
  • Append changelog with changes

@juldrixx juldrixx marked this pull request as draft November 15, 2023 09:54
@juldrixx juldrixx marked this pull request as ready for review November 15, 2023 11:13
@juldrixx juldrixx merged commit 427fbd5 into master Nov 15, 2023
4 checks passed
@juldrixx juldrixx deleted the feat/add_ability_to_set_nodeport branch November 15, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set port for NodePort type service
2 participants